feat(middleware): broaden HTTP header mutation authority - #3072
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 4b3b641 |
Response middleware could write or remove Set-Cookie, WWW-Authenticate, Authentication-Info, and Proxy-Authentication-Info, letting a stage plant or strip credentials the sandbox client acts on. Protect them in both directions, matching the request profile's treatment of Authorization and Cookie, and reserve the x-openshell-credential prefix for responses too. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-3072.docs.buildwithfern.com/openshell |
pimlock
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
This accepted-issue-backed change is internally consistent across the shared validator, request caller, protobuf contract, architecture note, and Fern middleware documentation. The independent code review found no blocking correctness or security defects; the pre-0.1 compatibility change is accepted as directed.
Action required: A maintainer or operator must separately authorize and apply test:e2e, then dispatch the current-head core E2E workflow. Gator did not apply the label or rerun workflows in this cycle.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Project-valid through accepted issue #2691; the PR implements its shared HTTP header-mutation authority criterion.
- Docs: Existing Fern middleware documentation and
architecture/sandbox.mdare updated; navigation is unchanged because no page was added or moved. - Checks:
OpenShell / Branch ChecksandOpenShell / Helm Lintpass at the current head; the required core E2E workflow has not been dispatched. - E2E:
test:e2eis required for middleware policy and credential-flow behavior, but applying the label or rerunning workflows was not authorized. - Head SHA:
2aff67735809b2cada33173f70cdb85347254d27 - Base SHA:
8ffc6c2a13cd482dea9e2195058309344c274756 - Merge base SHA:
8ffc6c2a13cd482dea9e2195058309344c274756 - Patch ID:
54c0839f2f2330b7624582f081891153af99bc2f - Gator payload:
8 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:blocked - Blocked reason:
test_dispatch_required
|
Label |
Summary
Remove the request-only header write namespace and centralize middleware header mutation checks. This is the base of the #2691 stack and keeps the authority change separate from response processing.
Related Issue
Part of #2691
Changes
x-openshell-middleware-prefix.Testing
mise run pre-commitpassesChecklist
Stack